fix(dgraph): making jemalloc to work with dgraph on macos #7247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aman-bansal
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
jarifibrahim
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Looks good to me. Just check with @danielmai if there was a reason to keep this disabled.
| # Only build with jemalloc on Linux | ||
| ifeq ($(GOOS),linux) | ||
| # Only build with jemalloc on Linux, mac | ||
| ifeq ($(GOOS),$(filter $(GOOS),linux darwin)) |
There was a problem hiding this comment.
@danielmai do you remember why we didn't enable jemalloc for mac initially?
aman-bansal
added a commit
that referenced
this pull request
Jan 12, 2021
* making jemalloc to work with dgraph on macos * updating ristretto to latest version * running it tidy
aman-bansal
added a commit
that referenced
this pull request
Jan 12, 2021
* making jemalloc to work with dgraph on macos * updating ristretto to latest version * running it tidy
aman-bansal
added a commit
that referenced
this pull request
Jan 12, 2021
…acos (#7247) (#7282) * fix(dgraph): making jemalloc to work with dgraph on macos (#7247) * making jemalloc to work with dgraph on macos * updating ristretto to latest version * running it tidy * fix(dgraph): making jemalloc to work with dgraph on macos (#7247) * making jemalloc to work with dgraph on macos * updating ristretto to latest version * running it tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is