fix(ludicrous): Fix data race in executor #7203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsanbarkati
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
jarifibrahim
approved these changes
Dec 24, 2020
worker/executor.go
Outdated
Comment on lines
188
to
189
| atomic.AddInt64(&dependent.inDeg, -1) | ||
| if atomic.LoadInt64(&dependent.inDeg) == 0 { |
There was a problem hiding this comment.
Suggested change
| atomic.AddInt64(&dependent.inDeg, -1) | |
| if atomic.LoadInt64(&dependent.inDeg) == 0 { | |
| if atomic.AddInt64(&dependent.inDeg, -1) == 0 { |
There was a problem hiding this comment.
It has been running fine since last night. I think this will fix the crash. I'll let it run for a day or two.
|
Can you please add a brief description in PR description about why this should be atomic? |
danielmai
pushed a commit
that referenced
this pull request
Dec 30, 2020
The operations on inDeg field of mutation struct should be done atomically because it is being used to check if a mutation in dependent on any other mutation. And the mutations are run concurrently, so this update/read on inDeg should be protected.
ahsanbarkati
added a commit
that referenced
this pull request
Jan 15, 2021
The operations on inDeg field of mutation struct should be done atomically because it is being used to check if a mutation in dependent on any other mutation. And the mutations are run concurrently, so this update/read on inDeg should be protected. (cherry picked from commit 49fd1f4)
ahsanbarkati
added a commit
that referenced
this pull request
Jan 15, 2021
The operations on inDeg field of mutation struct should be done atomically because it is being used to check if a mutation in dependent on any other mutation. And the mutations are run concurrently, so this update/read on inDeg should be protected. (cherry picked from commit 49fd1f4)
ahsanbarkati
added a commit
that referenced
this pull request
Jan 15, 2021
The operations on inDeg field of mutation struct should be done atomically because it is being used to check if a mutation in dependent on any other mutation. And the mutations are run concurrently, so this update/read on inDeg should be protected. (cherry picked from commit 49fd1f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operations on
inDegfield ofmutationstruct should be done atomically because it is being used to check if a mutation in dependent on any other mutation. And the mutations are run concurrently, so this update ininDegshould be protected. This change fixes the data race which results in alpha crash due to callingDoneon watermark which is lesser thandoneUntilPotential fix for: DGRAPH-2805
This change is