v20.07: fix(GraphQL): don't update cacheMb if not specified by user (GRAPHQL-… #7106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…888) (#7103) Fixes GRAPHQL-888. Previously, if you ran this request: ``` $ curl -H "Content-Type: application/json" http://localhost:8080/admin -d '{"query": "mutation {config(input: {logRequest: false}){response {code message}}}"}' ``` Alpha logs would also print this: ``` I1205 22:22:51.684693 2681396 middlewares.go:178] GraphQL admin mutation. Name = config I1205 22:22:51.684724 2681396 config.go:38] Got config update through GraphQL admin API I1205 22:22:51.684810 2681396 worker.go:138] Updating cacheMb to 0 ``` Indicating that cacheMb was also updated, even it wasn't specified in the request. This PR fixes this issue. (cherry picked from commit c03c327) # Conflicts: # graphql/admin/config.go
abhimanyusinghgaur
requested review from
MichaelJCompton and
pawanrawal
as code owners
github-actions
bot
added
the
area/graphql
|
✔️ Deploy preview for dgraph-docs ready! 🔨 Explore the source changes: f2b3605 🔍 Inspect the deploy logs: https://app.netlify.com/sites/dgraph-docs/deploys/5fd200d311407400072f9051 😎 Browse the preview: https://deploy-preview-7106--dgraph-docs.netlify.app |
abhimanyusinghgaur
changed the title
pawanrawal
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…888) (#7103)
Fixes GRAPHQL-888.
Previously, if you ran this request:
Alpha logs would also print this:
Indicating that cacheMb was also updated, even it wasn't specified in the request.
This PR fixes this issue.
(cherry picked from commit c03c327)
# Conflicts:
# graphql/admin/config.go
This change is