fix(protos): regenerate protos #7102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
abhimanyusinghgaur
approved these changes
Dec 10, 2020
danielmai
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)
danielmai
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
I've added a check during the CI build to check for proto differences:
cd ./protos
make regenerate
git diff --exit-code -- .
Reviewable status:
danielmai
added a commit
that referenced
this pull request
Jan 18, 2021
If the proto dependencies change, then they need to be fetched first before the
protos can be regenerated. For example, when Badger protos change then this
error can happen:
$ make regenerate
cp: cannot stat '/pb/badgerpb3.proto': No such file or directory
make: *** [Makefile:46: copy-protos] Error 1
Calling go get or go mod tidy fixes this issue:
$ go mod tidy
...
go: downloading github.com/dgraph-io/badger/v3 v3.0.0-20210113052537-b69163b5c21b
The dependencies need to be fetched in order to pick up the correct proto files
from the $GOMODCACHE directory using go list -m -f "{{.Dir}}".
Changes:
* Fetch dependencies (tidy-deps) before regenerating protos.
* Refactor Makefile with BADGER_PB_VERSION variable to make it
easier to update Badger version
* Add Go tests to regenerate the protos and check for
differences. This check originally added in CI in
#7102 (review).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is