perf(GraphQL): Part-1: Pagination for root user query is applied at root auth query (GRAPHQL-854) #7100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhimanyusinghgaur
requested review from
MichaelJCompton and
pawanrawal
as code owners
github-actions
bot
added
the
area/graphql
abhimanyusinghgaur
changed the title
abhimanyusinghgaur
changed the title
pawanrawal
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @abhimanyusinghgaur and @MichaelJCompton)
query/query.go, line 1995 at r1 (raw file):
suffix += "." + sg.Attr } if len(sg.Params.Var) > 0 {
Add a comment about this if block.
query/query.go, line 1998 at r1 (raw file):
suffix += "." + sg.Params.Alias } ctx, span := otrace.StartSpan(ctx, "query.ProcessGraph."+suffix)
Add a comment about why we do this as well.
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @MichaelJCompton and @pawanrawal)
query/query.go, line 1995 at r1 (raw file):
Previously, pawanrawal (Pawan Rawal) wrote…
Add a comment about this if block.
Done.
query/query.go, line 1998 at r1 (raw file):
Previously, pawanrawal (Pawan Rawal) wrote…
Add a comment about why we do this as well.
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the pagination parameters for root user query to root auth query. This greatly optimizes the number of nodes that need to be processed by child auth queries.
This change is