Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): fix eq filter for non-index predicates. #6986

Merged
merged 2 commits into from
Nov 25, 2020

Conversation

minhaj-shakeel
Copy link
Contributor

@minhaj-shakeel minhaj-shakeel commented Nov 25, 2020

Fixes DGRAPH-1781.

This PR backport the fix of eq filter on non-indexed predicate, which was fixed by #6715 earlier.

This PR fixes the eq filter for more than one argument on the non-indexed predicate which earlier used to compare with just the first of the given arguments for the eq filter. For eg for the given schema:

type CarModel {
	make
	model
	year
}
model                          : string @index(term) @lang .
make                           : string @index(term) .
year                           : int .

the below query was not giving proper results earlier.

queryCarModel(func: type(CarModel)) @filter(eq(year,2008,2009)){
				make
				model
				year
			}

This change is Reviewable

Copy link
Contributor

@OmarAyo OmarAyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @pawanrawal)

Copy link
Contributor

@OmarAyo OmarAyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @pawanrawal)

@OmarAyo OmarAyo merged commit 54ef639 into release/v20.03 Nov 25, 2020
OmarAyo pushed a commit that referenced this pull request Nov 25, 2020
* fix eq function with non indexed predicate

* remove tests for between function

(cherry picked from commit 54ef639)
OmarAyo added a commit that referenced this pull request Nov 25, 2020
* fix eq function with non indexed predicate

* remove tests for between function

(cherry picked from commit 54ef639)

Co-authored-by: minhaj-shakeel <[email protected]>
@minhaj-shakeel minhaj-shakeel deleted the minhaj/cherry-pick-eq-filter-bug branch April 22, 2021 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants