fix(GraphQL):This PR allows to use fragments on interfaces while querying other interface. #6964
Conversation
JatinDev543
requested review from
MichaelJCompton and
pawanrawal
as code owners
github-actions
bot
added
the
area/graphql
|
Deploy preview for dgraph-docs ready! Built with commit 08393f5 |
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jatindevdg, @MichaelJCompton, and @pawanrawal)
graphql/resolve/query_test.yaml, line 1939 at r2 (raw file):
"queryCharacter with fragment on interface and type"
fragment on interface implemented by type which implements multiple interfaces in query on some other interface
graphql/schema/request.go, line 285 at r2 (raw file):
Type
typ
local variables should always be lowercase. So, lets change this to typ (as type is a keyword)
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @abhimanyusinghgaur, @MichaelJCompton, and @pawanrawal)
graphql/resolve/query_test.yaml, line 1939 at r2 (raw file):
Previously, abhimanyusinghgaur (Abhimanyu Singh Gaur) wrote…
"queryCharacter with fragment on interface and type"fragment on interface implemented by type which implements multiple interfaces in query on some other interface
changed.
graphql/schema/request.go, line 285 at r2 (raw file):
Previously, abhimanyusinghgaur (Abhimanyu Singh Gaur) wrote…
Typetyp
local variables should always be lowercase. So, lets change this to
typ(astypeis a keyword)
Ohh...changed.
…ying other interface. (#6964) Fixes GRAPHQL-863 Consider the below schema, Human implements both character and Employee interfaces. interface Employee { ... } interface Character { ... } type Human implements Character & Employee { ... } type Droid implements Character { ... } While Querying Character interfaces which can return an object of Droid or Human, we will be able to use fragment on Employee interface if the returned object is of type Human and ignores it if the returned object is of type Droid. (cherry picked from commit f810e4e)
…ying other interface. (#6964) (#6966) Fixes GRAPHQL-863 Consider the below schema, Human implements both character and Employee interfaces. interface Employee { ... } interface Character { ... } type Human implements Character & Employee { ... } type Droid implements Character { ... } While Querying Character interfaces which can return an object of Droid or Human, we will be able to use fragment on Employee interface if the returned object is of type Human and ignores it if the returned object is of type Droid. (cherry picked from commit f810e4e)
Fixes GRAPHQL-863
Consider the below schema, Human implements both character and Employee interfaces.
While Querying
Characterinterfaces which can return an object of Droid or Human, we will be able to use fragment onEmployeeinterface if the returned object is of typeHumanand ignores it if the returned object is of typeDroid.This change is