fix(GraphQL): handle filters for enum properly (#6887) #6916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a breaking change for the `eq` filter on the List of `enum` Types.
This PR fixes bugs in the filter generated for enum types. For the given schema:-
```
enum Status {
ACTIVE
DEACTIVATED
}
type VerificationFilter {
status: [Status]! @search
}
```
the `hash` filter generated for `status` was:
```
input Status_hash {
eq: [Status]!
in: [Status]
}
```
whereas, it should be:
```
input Status_hash {
eq: Status
in: [Status]
}
```
This PR also fixes incorrect filter generated for `exact` index in List of enum types.
Earlier it was being generated like:
```
input Status_exact {
eq: [Status]
in: [Status]
le: [Status]
lt: [Status]
ge: [Status]
gt: [Status]
between: Status
}
```
but it should be like:
```
input Status_exact {
eq: Status
in: [Status]
le: Status
lt: Status
ge: Status
gt: Status
between: Status
}
```
Breaking change lies in the generation of `eq` filters. Earlier it was `eq: [Status]!` but now it is `eq: Status`. Both are syntactically fine but `eq: [Status]!` conflicts with the expected usage of `eq` filter.
(cherry picked from commit 40b20c7)
minhaj-shakeel
requested review from
MichaelJCompton and
pawanrawal
as code owners
github-actions
bot
added
the
area/graphql
pawanrawal
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a breaking change for the
eqfilter on the List ofenumTypes.This PR fixes bugs in the filter generated for enum types. For the given schema:-
the
hashfilter generated forstatuswas:whereas, it should be:
This PR also fixes incorrect filter generated for
exactindex in List of enum types.Earlier it was being generated like:
but it should be like:
Breaking change lies in the generation of
eqfilters. Earlier it waseq: [Status]!but now it iseq: Status. Both are syntactically fine buteq: [Status]!conflicts with the expected usage ofeqfilter.(cherry picked from commit 40b20c7)
This change is