-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(xidmap): Use btree with hash of keys for xidmap #6902
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsanbarkati
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
November 17, 2020 14:28
xidmap/xidmap.go, line 206 at r1 (raw file):
Push it to a channel. |
xidmap/xidmap.go, line 81 at r1 (raw file):
Use farm fingerprint |
xidmap/xidmap.go, line 206 at r1 (raw file): Previously, ahsanbarkati (Ahsan Barkati) wrote…
Batch the kvs to 64 and then push them to the channel. |
jarifibrahim
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run this locally as well.
ahsanbarkati
added a commit
that referenced
this pull request
Nov 20, 2020
Use B+ tree with the hash of xid in xidmap. (cherry picked from commit 6a18d84)
ahsanbarkati
added a commit
that referenced
this pull request
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add b+ tree as an underlying data structure for xidmap.
This change is
Docs Preview: