Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(xidmap): Use btree with hash of keys for xidmap #6902

Merged
merged 5 commits into from
Nov 19, 2020

Conversation

ahsanbarkati
Copy link
Contributor

@ahsanbarkati ahsanbarkati commented Nov 17, 2020

Add b+ tree as an underlying data structure for xidmap.


This change is Reviewable

Docs Preview: Dgraph Preview

@ahsanbarkati
Copy link
Contributor Author


xidmap/xidmap.go, line 206 at r1 (raw file):

			x.Panic(err)
		}
	}

Push it to a channel.

@ahsanbarkati
Copy link
Contributor Author


xidmap/xidmap.go, line 81 at r1 (raw file):

	return h.Sum64()
}

Use farm fingerprint

@ahsanbarkati
Copy link
Contributor Author


xidmap/xidmap.go, line 206 at r1 (raw file):

Previously, ahsanbarkati (Ahsan Barkati) wrote…

Push it to a channel.

Batch the kvs to 64 and then push them to the channel.

Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run this locally as well.

xidmap/xidmap.go Outdated Show resolved Hide resolved
xidmap/xidmap.go Outdated Show resolved Hide resolved
xidmap/xidmap.go Outdated Show resolved Hide resolved
xidmap/xidmap.go Outdated Show resolved Hide resolved
@ahsanbarkati ahsanbarkati merged commit 6a18d84 into master Nov 19, 2020
@ahsanbarkati ahsanbarkati deleted the ahsan/xidmap-btree branch November 19, 2020 09:57
ahsanbarkati added a commit that referenced this pull request Nov 20, 2020
Use B+ tree with the hash of xid in xidmap.

(cherry picked from commit 6a18d84)
ahsanbarkati added a commit that referenced this pull request Nov 23, 2020
Use B+ tree with the hash of xid in xidmap.

(cherry picked from commit 6a18d84)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants