Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GraphQL): This PR adds support for "application/dql" in content header. #6849

Merged
merged 4 commits into from
Nov 5, 2020

Conversation

JatinDev543
Copy link
Contributor

@JatinDev543 JatinDev543 commented Nov 5, 2020

Fixes GRAPHQL-706

This PR Add support for below header in query endpoint

curl -H "Content-Type: application/dql" "localhost:8080/query"

We are also keeping support for the old header.

curl -H "Content-Type: application/graphql+-" "localhost:8080/query"


This change is Reviewable

Docs Preview: Dgraph Preview

@github-actions github-actions bot added area/bulk-loader Issues related to bulk loading. area/enterprise Related to proprietary features area/documentation Documentation related issues. area/graphql Issues related to GraphQL support on Dgraph. area/integrations Related to integrations with other projects. area/testing Testing related issues labels Nov 5, 2020
Copy link
Contributor

@pawanrawal pawanrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 14 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @danielmai, @manishrjain, @MichaelJCompton, and @vvbalaji-dgraph)

@JatinDev543 JatinDev543 merged commit 5a5f131 into master Nov 5, 2020
@JatinDev543 JatinDev543 deleted the GRAPHQL-706 branch November 5, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bulk-loader Issues related to bulk loading. area/documentation Documentation related issues. area/enterprise Related to proprietary features area/graphql Issues related to GraphQL support on Dgraph. area/integrations Related to integrations with other projects. area/testing Testing related issues
Development

Successfully merging this pull request may close these issues.

2 participants