Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GraphQL): Mutations with Auth on interfaces should work correctly. #6839

Merged
merged 10 commits into from
Nov 5, 2020
Merged

feat(GraphQL): Mutations with Auth on interfaces should work correctly. #6839

merged 10 commits into from
Nov 5, 2020

Conversation

minhaj-shakeel
Copy link
Contributor

@minhaj-shakeel minhaj-shakeel commented Nov 4, 2020 •
edited
Loading

This PR extends support for Mutation with Auth on interfaces.

This change is Reviewable

Docs Preview: Dgraph Preview

minhaj-shakeel and others added 6 commits October 22, 2020 10:17
@minhaj-shakeel
feat(GraphQL): Types Should be able to inherit Auth Rules from Interf…
ca10f66 
…aces (#6757)

Fixes GRAPHQL-664.

This PR allows interfaces to have `@auth` rules and Types should be able to inherit those auth rules along with its own auth rules.
@minhaj-shakeel
feat(GraphQL): Auth on Interfaces should work correctly while queryin…
8cb4705 
…g them. (#6781)

Fixes GRAPHQL-660.
@minhaj-shakeel
merge master
dbad5a8
@minhaj-shakeel
fix prev tests
0bfd818
@minhaj-shakeel
Merge branch 'master' into minhaj/auth-on-interfaces
1eae144
@minhaj-shakeel
feat(GraphQL): types should be able to inherit mutation auth rules fr…
172ed2d 
…om interfaces (#6816)

Fixes GRAPHQL-740.
pawanrawal
pawanrawal approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@pawanrawal pawanrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good but some CI tests are failing. Feel free to merge once they pass.

@minhaj-shakeel minhaj-shakeel merged commit df37c2b into master Nov 5, 2020
@minhaj-shakeel minhaj-shakeel deleted the minhaj/auth-on-interfaces branch November 5, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanrawal pawanrawal pawanrawal approved these changes

@MichaelJCompton MichaelJCompton Awaiting requested review from MichaelJCompton

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minhaj-shakeel @pawanrawal