Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tls): splitting tls_dir + making health point available on HTTP #6821

Merged
merged 3 commits into from
Nov 3, 2020

Conversation

aman-bansal
Copy link
Contributor

@aman-bansal aman-bansal commented Nov 2, 2020

Fixes DGRAPH-1263 and DGRAPH-599
This PR aims two things:

  1. split tls_dir to tls_cacert, tls_node_key, tls_node_cert. This is more industry standard.
  2. for orchestrator like kubernetes, health endpoint needs to be without any authentication. This PR make health endpoint available at HTTP for both zero and alpha

This change is Reviewable

@github-actions github-actions bot added the area/integrations Related to integrations with other projects. label Nov 2, 2020
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 24 files at r1.
Reviewable status: 7 of 24 files reviewed, 1 unresolved discussion (waiting on @aman-bansal, @manishrjain, and @vvbalaji-dgraph)


x/server.go, line 51 at r1 (raw file):

	if tlsConf != nil {
		httpsRule := m.Match(cmux.Any())
		//this is chained listener. tls listener will decrypt the message and send it in plain text to HTTP server

Keep it under 100 characters per line.

@aman-bansal aman-bansal merged commit 161f889 into master Nov 3, 2020
@aman-bansal aman-bansal deleted the aman/tls_opts branch November 9, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations Related to integrations with other projects.
Development

Successfully merging this pull request may close these issues.

2 participants