fix(export): don't return an error if there was no GraphQL schema #6815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhimanyusinghgaur
requested review from
manishrjain,
MichaelJCompton,
pawanrawal and
vvbalaji-dgraph
as code owners
github-actions
bot
added
the
area/graphql
pawanrawal
approved these changes
Nov 3, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain, @MichaelJCompton, and @vvbalaji-dgraph)
jarifibrahim
approved these changes
Nov 3, 2020
danielmai
pushed a commit
that referenced
this pull request
Mar 26, 2021
Cherry-pick of #6815. FIxes GRAPHQL-747 Fixes [Discuss Issue](https://discuss.dgraph.io/t/multiple-values-for-the-graphql-schema/10881) This PR fixes the issue where you would get an error, if you first add a GraphQL schema, then delete the GraphQL schema using `<uid> * *` delete mutation and try to export the DB.
danielmai
pushed a commit
that referenced
this pull request
Mar 26, 2021
Cherry-pick of #6815. FIxes GRAPHQL-747 Fixes [Discuss Issue](https://discuss.dgraph.io/t/multiple-values-for-the-graphql-schema/10881) This PR fixes the issue where you would get an error, if you first add a GraphQL schema, then delete the GraphQL schema using `<uid> * *` delete mutation and try to export the DB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes GRAPHQL-747
Fixes Discuss Issue
This PR fixes the issue where you would get an error, if you first add a GraphQL schema, then delete the GraphQL schema using
<uid> * *delete mutation and try to export the DB.This change is