feat(GraphQL): add support for all RSA and HMAC algorithms supported … #6750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dan-j
force-pushed
the
jwt-algorithms
branch
2 times, most recently
from
741d35d to
3f4c972
Compare
…by github.com/dgrijalva/jwt-go/v4 Signed-off-by: dan-j <[email protected]>
pawanrawal
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…by github.com/dgrijalva/jwt-go/v4
Signed-off-by: dan-j [email protected]
Posted to discuss: https://discuss.dgraph.io/t/graphql-support-more-jwt-algorithms/10999
The GraphQL JWT authorisation feature only supported HS256 and RS256 when the underlying library dealing with JWTs (github.com/dgrijalva/jwt-go/v4) supports many more.
This PR adds support for all HMAC and RSA signing keys. I have purposefully left out the other algorithms since I don't know much about them and whether they need treating differently when it comes to keys etc.
This change is