Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GraphQL): Unions #6722

Merged
merged 15 commits into from
Oct 19, 2020
Merged

feat(GraphQL): Unions #6722

merged 15 commits into from
Oct 19, 2020

Conversation

abhimanyusinghgaur
Copy link
Contributor

@abhimanyusinghgaur abhimanyusinghgaur commented Oct 14, 2020

Fixes GRAPHQL-676
This PR adds union support to GraphQL.
See RFC for more details.


This change is Reviewable

Docs Preview: Dgraph Preview

…nion-execution

# Conflicts:
#	graphql/e2e/directives/schema.graphql
#	graphql/e2e/normal/schema.graphql
#	graphql/e2e/normal/schema_response.json
#	graphql/resolve/mutation_rewriter.go
#	graphql/resolve/query_rewriter.go
#	graphql/schema/gqlschema.go
#	graphql/schema/gqlschema_test.yml
#	graphql/schema/schemagen.go
…nion-execution

# Conflicts:
#	graphql/e2e/directives/schema.graphql
#	graphql/e2e/normal/schema.graphql
#	graphql/e2e/normal/schema_response.json
#	graphql/resolve/mutation_rewriter.go
#	graphql/resolve/query_rewriter.go
#	graphql/schema/gqlschema.go
#	graphql/schema/gqlschema_test.yml
#	graphql/schema/schemagen.go
@abhimanyusinghgaur abhimanyusinghgaur changed the base branch from abhimanyu/graphql-unions to master October 14, 2020 11:20
@abhimanyusinghgaur abhimanyusinghgaur changed the title feat(GraphQL): Unions Part 2 - Execution feat(GraphQL): Unions Oct 14, 2020
Copy link
Contributor

@pawanrawal pawanrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

graphql/resolve/query_rewriter.go Show resolved Hide resolved
graphql/resolve/add_mutation_test.yaml Outdated Show resolved Hide resolved
graphql/resolve/add_mutation_test.yaml Outdated Show resolved Hide resolved
@abhimanyusinghgaur abhimanyusinghgaur merged commit 0c28a88 into master Oct 19, 2020
@abhimanyusinghgaur abhimanyusinghgaur deleted the abhimanyu/union-execution branch October 19, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants