Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dgraph): Add ability to change size of caches through the admin interface. #6644

Merged
merged 17 commits into from
Oct 8, 2020

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Oct 4, 2020

The endpoints have been changed from lruMb to cacheMb to reflect that this
is changing the value of the cacheMb flag.

Fixes DGRAPH-2515


This change is Reviewable

Docs Preview: Dgraph Preview

@martinmr martinmr marked this pull request as draft October 4, 2020 17:12
Base automatically changed from martinmr/remove-lru-mb to master October 5, 2020 22:43
@martinmr
Copy link
Contributor Author

martinmr commented Oct 6, 2020

CI is failing because the cache sizes need to be properly initialized. Once branch martinmr/wal is merged into master, CI should start working again.

@martinmr martinmr marked this pull request as ready for review October 6, 2020 23:56
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Ensure build is still green after this.

Reviewed 16 of 16 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai, @martinmr, @MichaelJCompton, @pawanrawal, and @vvbalaji-dgraph)


worker/worker.go, line 131 at r1 (raw file):

// UpdateCacheMb updates the value of cache_mb and updates the corresponding cache sizes.
func UpdateCacheMb(memoryMB int64) error {
	glog.Infof("memoryMB %d", memoryMB)

Updating cacheMB to ...

Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 8 rules errored during the review.

Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 8 rules errored during the review.

@martinmr martinmr merged commit b6a9060 into master Oct 8, 2020
@martinmr martinmr deleted the martinmr/update-cache-size branch October 8, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants