-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Dgraph): Add ability to change size of caches through the admin interface. #6644
Conversation
CI is failing because the cache sizes need to be properly initialized. Once branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure build is still green after this.
Reviewed 16 of 16 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai, @martinmr, @MichaelJCompton, @pawanrawal, and @vvbalaji-dgraph)
worker/worker.go, line 131 at r1 (raw file):
// UpdateCacheMb updates the value of cache_mb and updates the corresponding cache sizes. func UpdateCacheMb(memoryMB int64) error { glog.Infof("memoryMB %d", memoryMB)
Updating cacheMB to ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 8 rules errored during the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 8 rules errored during the review.
The endpoints have been changed from lruMb to cacheMb to reflect that this
is changing the value of the cacheMb flag.
Fixes DGRAPH-2515
This change is
Docs Preview: