-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Dgraph): Use Badger with new WAL format. #6643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Let's get it merged asap.
Reviewed 6 of 15 files at r1, 3 of 9 files at r2, 5 of 7 files at r3, 7 of 8 files at r5, 1 of 1 files at r6, 2 of 2 files at r7.
Reviewable status: 23 of 26 files reviewed, 3 unresolved discussions (waiting on @jarifibrahim and @manishrjain)
go.sum, line 166 at r7 (raw file):
github.com/google/codesearch v1.0.0 h1:z4h5JoHkUS+GqxqPDrldC3Y0Qq0vHAGgaDEW5pWU/ys= github.com/google/codesearch v1.0.0/go.mod h1:qCnXDFnak/trCmLaE50kgPte3AX9jSeruZexWEOivi0= github.com/google/flatbuffers v1.12.0 h1:/PtAHvnBY4Kqnx/xCQ3OIV9uYcSFGScBsWI3Oogeh6w=
go mod tidy
test.sh, line 244 at r7 (raw file):
if [[ :${TEST_SET}: == *:systest:* ]]; then # TODO: Fix this test. The fix consists of updating the test script to
This test isn't that useful. So, disabling it for now.
dgraph/cmd/bulk/run.go, line 114 at r7 (raw file):
"The compression level for Badger. A higher value uses more resources.") flag.Int64("badger.cache_mb", 64, "Total size of cache (in MB) per shard in reducer.") flag.String("badger.cache_percentage", "100,0",
maybe 70,30
This PR moves Dgraph to the new version of Badger that includes the new WAL. Some changes were
needed to make this work in Dgraph.
support mmap.
This change is
Docs Preview: