fix(gqlParser): Handle strings with only whitespace in parseID #6615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarifibrahim
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
jarifibrahim
changed the title
github-actions
bot
added
the
area/querylang
pawanrawal
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @abhimanyusinghgaur, @manishrjain, and @vvbalaji-dgraph)
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 7, 2020
ParseID function would panic if the input consists of only whitespace characters. This PR fixes it. Fixes GRAPHQL-720 (cherry picked from commit d994cb3) Conflicts: gql/parser_test.go
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 7, 2020
ParseID function would panic if the input consists of only whitespace characters. This PR fixes it. Fixes GRAPHQL-720 (cherry picked from commit d994cb3) Conflicts: gql/parser_test.go
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 7, 2020
ParseID function would panic if the input consists of only whitespace characters. This PR fixes it. Fixes GRAPHQL-720 (cherry picked from commit d994cb3) Conflicts: gql/parser_test.go
jarifibrahim
pushed a commit
that referenced
this pull request
Nov 2, 2020
jarifibrahim
pushed a commit
that referenced
this pull request
Nov 2, 2020
jarifibrahim
pushed a commit
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParseID function would panic if the input consists of only whitespace characters. This PR fixes it.
Fixes GRAPHQL-720
This change is