feat(query): Support for between func with count at root #6556
Conversation
ashish-goswami
requested review from
manishrjain,
pawanrawal and
vvbalaji-dgraph
as code owners
| illegal = count <= 0 | ||
| illegal = countl <= 0 | ||
| case "between": | ||
| illegal = countl <= 0 || counth <= 0 |
There was a problem hiding this comment.
another check could be countl > counth
There was a problem hiding this comment.
We are not returning any error in case of improper bounds. Returned response would be empty.
There was a problem hiding this comment.
I think we should just check that case here as we are already checking other illegal cases.
There was a problem hiding this comment.
Agreed. But the point is not to return error from here, to have between behaviour consistent.
| return err | ||
| } | ||
| if cp.fn == between && int64(k.Count) > counth { | ||
| break |
There was a problem hiding this comment.
I thought we will continue here to the next item and not break, no?
There was a problem hiding this comment.
We need to break here as soon as we cross the upper bound in case of between.
There was a problem hiding this comment.
Is it because all future keys count will be higher. (i.e keys are sorted?)
This change is
Docs Preview: