fix(dgraph): Update alpha http handler to handle params in content-type header #6540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulgurnani
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
![codelingo[bot]](https://avatars.githubusercontent.com/in/14339?s=60&v=4){kind=small}
|
Branch has conflicts. Please merge and update your PR. |
|
#6370 already addresses this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5174
Earlier, if we send "Content-Type" as "application/json; charset=utf8" query failed. The content-type http header allows params and our code didn't take those into account.
Docs for Content-Type header: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type
Added dependency to gddo/httputil/header package which has a utility to parse the headers.
Also added a test for this change.
This change is