CP(20.03): Fix(increment): Fix readTs less than minTs (#6317) #6518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the readTs for reads via LocalCache. This would ensure that users don't get a lot of ReadTs less than MinTs errors. This PR also fixes the flaky test in increment_test.go. This has a side-effect on posting list cache. That cache would need to understand versioning to be effective. Co-authored-by: Daniel Mai <[email protected]> (cherry picked from commit 2de4675)
parasssh
requested review from
manishrjain,
martinmr and
a team
as code owners
parasssh
changed the title
martinmr
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @manishrjain and @martinmr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the readTs for reads via LocalCache. This would ensure that users don't get a lot of ReadTs less than MinTs errors. This PR also fixes the flaky test in increment_test.go.
This has a side-effect on posting list cache. That cache would need to understand versioning to be effective.
Co-authored-by: Daniel Mai [email protected]
(cherry picked from commit 2de4675)
This change is
Docs Preview: