fix(Alpha): Immediately take a snapshot if we don't have one #6458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested the fix and it solves the issue |
martinmr
approved these changes
Sep 15, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain and @vvbalaji-dgraph)
worker/draft.go, line 991 at r1 (raw file):
is already crosses
nit: already crossed
OmarAyo
pushed a commit
that referenced
this pull request
Nov 24, 2020
This PR would cause the Alpha leader to immediately trigger a snapshot creation if it doesn't already have one. This is useful when you bring a new cluster from bulk loader. If you remove an Alpha instance and add a new Alpha instance, the new follower won't get a snapshot if the leader doesn't have one. This PR avoids that by causing the leader to get a snapshot asap. Fixes DGRAPH-2445 (cherry picked from commit 6bd7f8e)
OmarAyo
pushed a commit
that referenced
this pull request
Nov 24, 2020
This PR would cause the Alpha leader to immediately trigger a snapshot creation if it doesn't already have one. This is useful when you bring a new cluster from bulk loader. If you remove an Alpha instance and add a new Alpha instance, the new follower won't get a snapshot if the leader doesn't have one. This PR avoids that by causing the leader to get a snapshot asap. Fixes DGRAPH-2445 (cherry picked from commit 6bd7f8e)
OmarAyo
added a commit
that referenced
this pull request
Nov 24, 2020
…6969) This PR would cause the Alpha leader to immediately trigger a snapshot creation if it doesn't already have one. This is useful when you bring a new cluster from bulk loader. If you remove an Alpha instance and add a new Alpha instance, the new follower won't get a snapshot if the leader doesn't have one. This PR avoids that by causing the leader to get a snapshot asap. Fixes DGRAPH-2445 (cherry picked from commit 6bd7f8e) Co-authored-by: Manish R Jain <[email protected]>
OmarAyo
added a commit
that referenced
this pull request
Nov 24, 2020
…6970) This PR would cause the Alpha leader to immediately trigger a snapshot creation if it doesn't already have one. This is useful when you bring a new cluster from bulk loader. If you remove an Alpha instance and add a new Alpha instance, the new follower won't get a snapshot if the leader doesn't have one. This PR avoids that by causing the leader to get a snapshot asap. Fixes DGRAPH-2445 (cherry picked from commit 6bd7f8e) Co-authored-by: Manish R Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would cause the Alpha leader to immediately trigger a snapshot creation if it doesn't already have one.
This is useful when you bring a new cluster from bulk loader. If you remove an Alpha instance and add a new Alpha instance, the new follower won't get a snapshot if the leader doesn't have one. This PR avoids that by causing the leader to get a snapshot asap.
Fixes DGRAPH-2445
This change is