fix(GraphQL): Remove auth error from mutation.

[arijitAD]

Fixes GRAPHQL-595
Discuss Issue

• Auth errors are only returned in debug mode which is turned off by default.

---

This change is 

[pawanrawal]

There should be a way to set this flag through an API ideally because otherwise Slash users can't make use of it.

Reviewed 20 of 20 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @arijitAD, @manishrjain, @MichaelJCompton, and @vvbalaji-dgraph)

---

dgraph/cmd/alpha/run.go, line 203 at r1 (raw file):

	flag.Bool("graphql_introspection", true, "Set to false for no GraphQL schema introspection")
	flag.Bool("graphql_debug", false, "Enable debug_off mode in GraphQL")

Enable debug mode in GraphQL. This returns auth errors to clients. We do not reccomend turning it on for production.

---

graphql/e2e/auth/add_mutation_test.go, line 29 at r1 (raw file):

)

func (us *UserSecret) delete(t *testing.T, user, role string) {

Any tests which show the behavior when graphql_debug is false?

---

graphql/e2e/auth/add_mutation_test.go, line 192 at r1 (raw file):

		if tcase.result == "" {
			require.Equal(t, len(gqlResponse.Errors), 1)
			require.Contains(t, gqlResponse.Errors[0].Message, "authorization failed")

So we still get this error if graphql_debug is set to true?

---

x/config.go, line 37 at r1 (raw file):

	// GraphqlExtension will be set to see extensions in graphql results
	GraphqlExtension bool
	// GraphqlDebug will enable debug_off mode in GraphQL

whats debug_off mode? Shouldn't it be debug mode?

[arijitAD]

Reviewable status: 18 of 20 files reviewed, 4 unresolved discussions (waiting on @manishrjain, @MichaelJCompton, @pawanrawal, and @vvbalaji-dgraph)

---

dgraph/cmd/alpha/run.go, line 203 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Enable debug mode in GraphQL. This returns auth errors to clients. We do not reccomend turning it on for production.

Done.

---

graphql/e2e/auth/add_mutation_test.go, line 29 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Any tests which show the behavior when graphql_debug is false?

I have added E2E test here with debug mode off.
graphql/e2e/auth/debug_off/debugoff_test.go

---

graphql/e2e/auth/add_mutation_test.go, line 192 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

So we still get this error if graphql_debug is set to true?

Yes. Ifgraphql_debugis set to true it will throw auth errors.

---

x/config.go, line 37 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

whats debug_off mode? Shouldn't it be debug mode?

Yes. Changed it. debug was changed to debug_off when I was refactoring code in IDE.

[pawanrawal]

Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain, @MichaelJCompton, @pawanrawal, and @vvbalaji-dgraph)

[arijitAD]

There should be a way to set this flag through an API ideally because otherwise Slash users can't make use of it.
I will create a JIRA ticket so that we would be able to change flags using API.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain, @MichaelJCompton, @pawanrawal, and @vvbalaji-dgraph)