fix(raft): Only leader should check the quorum #6323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Checkquorum() function is used by the leader to determine if it is still a leader and not behind a network partition (split-head situation).
jarifibrahim
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
manishrjain
suggested changes
Sep 3, 2020
There was a problem hiding this comment.
Run this with blockade.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jarifibrahim, @manishrjain, and @vvbalaji-dgraph)
dgraph/cmd/zero/raft.go, line 64 at r1 (raw file):
func (n *node) AmLeader() bool { // Return false if the node is not the leader. Otherwise, check the lastQuorum as well. return n.amLeader() && func() bool {
This is unusual way of writing an if statement.
manishrjain
reviewed
Sep 3, 2020
There was a problem hiding this comment.
If it works with Blockade, then good to go.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jarifibrahim, @manishrjain, and @vvbalaji-dgraph)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Checkquorum() function is used by the leader to determine if it is
still a leader and not behind a network partition (split-head situation).
The current code would checkquorum even for followers which isn't necessary.
This PR removes the quorum check for followers.
This change is