Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GraphQL): GraphQL now has Int64 as scalar type #6200

Merged
merged 4 commits into from
Aug 18, 2020
Merged

feat(GraphQL): GraphQL now has Int64 as scalar type #6200

merged 4 commits into from
Aug 18, 2020

Conversation

abhimanyusinghgaur
Copy link
Contributor

@abhimanyusinghgaur abhimanyusinghgaur commented Aug 17, 2020 •
edited
Loading

Fixes GRAPHQL-606
Fixes Discuss Issue
This PR adds Int64 as a scalar type in GraphQL. Note that:

The Int64 scalar type represents a signed 64‐bit numeric non‐fractional value.
Int64 can currently represent values in range [-(2^53)+1, (2^53)-1] without any error.
Values out of this range but representable by a signed 64-bit integer, may get coercion error.

This limit on the range of numbers is because of the current JSON implementation used and is explained in detail in the JSON RFC

This change is Reviewable

Docs Preview: Dgraph Preview

@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Aug 17, 2020
@abhimanyusinghgaur abhimanyusinghgaur marked this pull request as ready for review August 17, 2020 09:36
pawanrawal
pawanrawal approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@pawanrawal pawanrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Nice and easy, well done! Once you merge this, please also comment on the GitHub issue which asked for this to say its available in master and would be part of the 20.11.0 release.

Reviewed 52 of 52 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MichaelJCompton)

@abhimanyusinghgaur abhimanyusinghgaur merged commit 18ce64a into master Aug 18, 2020
@abhimanyusinghgaur abhimanyusinghgaur deleted the abhimanyu/int64 branch August 18, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanrawal pawanrawal pawanrawal approved these changes

@MichaelJCompton MichaelJCompton Awaiting requested review from MichaelJCompton

Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhimanyusinghgaur @pawanrawal