Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics cost to grpc and http header #6148

Merged
merged 8 commits into from
Aug 10, 2020
+133 −1
Merged

feat: add metrics cost to grpc and http header #6148

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a51e479
add query cost to the header
Aug 7, 2020
8dec1ff
fix panic
poonai Aug 7, 2020
622a4c7
fix minor
poonai Aug 7, 2020
e23efa5
change header name
Aug 7, 2020
d184b13
return resp instead of cost
Aug 7, 2020
78e9b6b
minor
Aug 7, 2020
d0fac74
Update x.go
gja Aug 7, 2020
f155463
add comment
Aug 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change header name 
Signed-off-by: பாலாஜி <balaji@dgraph.io>
பாலாஜி committed Aug 7, 2020
commit e23efa506b2d4f75a60658147a5f2722324adaf5
2 changes: 1 addition & 1 deletion x/x.go
View file
Original file line number Diff line number Diff line change
@@ -146,7 +146,7 @@ const (
AccessControlAllowedHeaders = "X-Dgraph-AccessToken, " +
"Content-Type, Content-Length, Accept-Encoding, Cache-Control, " +
"X-CSRF-Token, X-Auth-Token, X-Requested-With"
DgraphCostHeader = "X-Dgraph-Cost"
DgraphCostHeader = "numUids"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I should have been explicit 🙈.. Let's keep it similar to graphql.

Dgraph-TouchedUids


// GraphqlPredicates is the json representation of the predicate reserved for graphql system.
GraphqlPredicates = `