fix(GraphQL): Fix getType queries when id was used as a name for types other than ID #6130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
abhimanyusinghgaur
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
So
getTweetswould work if the field was named anything other thanid.
So getTweets would work if the field was named anything, even id.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MichaelJCompton)
JatinDev543
pushed a commit
that referenced
this pull request
Aug 13, 2020
…s other than ID (#6130) For the schema type Tweets { id: String! @id score: Int } getTweets query was not being properly re-written. This is because we were using the name id to signify that a field is of type ID instead of the type ID itself. That has been fixed now. So getTweets would work if the field was named anything. query MyQuery { getTweets(id: "1286891968727982081") { score id } } (cherry picked from commit bb8e4b9)
JatinDev543
added a commit
that referenced
this pull request
Aug 14, 2020
…s other than ID (#6130) (#6180) For the schema type Tweets { id: String! @id score: Int } getTweets query was not being properly re-written. This is because we were using the name id to signify that a field is of type ID instead of the type ID itself. That has been fixed now. So getTweets would work if the field was named anything. query MyQuery { getTweets(id: "1286891968727982081") { score id } } (cherry picked from commit bb8e4b9) Co-authored-by: Pawan Rawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the schema
getTweets query was not being properly re-written. This is because we were using the name
idto signify that a field is of typeIDinstead of the typeIDitself. That has been fixed now. SogetTweetswould work if the field was named anything.This change is