fix(GraphQL): fix interface conversion panic in v20.03 #5857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DGRAPH-1787.
This PR fixes an issue, where if some user accidentally deleted the
dgraph.type
edge for the GraphQL schema node and simultaneously added another GraphQL schema node withdgraph.type
edge and restarted the alpha, it would end up crashing with a panic sayingpanic: interface conversion: interface {} is nil, not string
.Steps to reproduce:
dgraph.type
edge from the existing schema node, and add a new node with justdgraph.type
edge.The reason it happens is that the code in 20.03 used to do the initial GraphQL schema upsert using the type query, and when you restart the alpha, it will find the new node which doesn't have the
dgraph.graphql.schema
edge. So, it comes as nil in query, and hence the panic.This change is
Docs Preview: