Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(deploy): Add more examples for whitelist config. #5694

Merged
merged 5 commits into from
Dec 21, 2020

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Jun 19, 2020

The --whitelist option has accepted CIDR flags and hostnames since #2953.


This change is Reviewable

Docs Preview: Dgraph Preview

@github-actions github-actions bot added the area/documentation Documentation related issues. label Jun 19, 2020
Copy link
Contributor

@parasssh parasssh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor coment. Feel free to resolve.

@bucanero
Copy link
Contributor

Hello @danielmai
is this PR still valid? if it's still accurate, I can add these changes to the deploy/dgraph-administration.md article

let me know, thanks!

@danielmai
Copy link
Contributor Author

@bucanero Yup, the changes in this PR are still valid. Can you move them to the right spot? Thanks!

@bucanero bucanero self-requested a review December 21, 2020 19:14
@bucanero bucanero merged commit 7310fae into master Dec 21, 2020
@bucanero bucanero deleted the danielmai/docs-whitelist branch December 21, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation related issues.
Development

Successfully merging this pull request may close these issues.

3 participants