Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update badger to commit e7b6e76f96e8 #5537

Merged
merged 2 commits into from
May 28, 2020
Merged

Update badger to commit e7b6e76f96e8 #5537

merged 2 commits into from
May 28, 2020

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented May 28, 2020

This PR updates badger and enables storing indices in the cache which was added via dgraph-io/badger#1336


This change is Reviewable

Also, Enable storing indices in cache.
@jarifibrahim jarifibrahim force-pushed the ibrahim/update-29/05 branch from ea21472 to 324cbcc Compare May 28, 2020 21:03
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was tested with flock for 5 hours. :lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)

@danielmai danielmai merged commit ba217bc into master May 28, 2020
@danielmai danielmai deleted the ibrahim/update-29/05 branch May 28, 2020 23:33
@manishrjain
Copy link
Contributor

Looks good.

dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
* Update badger to commit e7b6e76f96e8

Also, enable storing indices in cache.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants