During shutdown, generate snapshot before closing raft node. #5476
Conversation
This will prevent trySnapshot from trying to send a range to the index range channel before it's closed.
martinmr
force-pushed
the
martinmr/close-range
branch
from
638d06c to
acfbf8c
Compare
martinmr
changed the title
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martinmr and @vvbalaji-dgraph)
dgraph/cmd/zero/run.go, line 296 at r1 (raw file):
_ = httpListener.Close() // Try to generate a snapshot before the shutdown. st.node.trySnapshot(0)
We could do it after the node.closer and before the store closer, I think. Ask @ashish-goswami .
Ideally, we finish up whatever the node had, and take a snapshot after.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ashish-goswami, @manishrjain, and @vvbalaji-dgraph)
dgraph/cmd/zero/run.go, line 296 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
We could do it after the node.closer and before the store closer, I think. Ask @ashish-goswami .
Ideally, we finish up whatever the node had, and take a snapshot after.
Done.
This will prevent trySnapshot from trying to send a range to the index range channel before it's closed.
This will prevent trySnapshot from trying to send a range to the index range channel before it's closed.
…deinc#5476) This will prevent trySnapshot from trying to send a range to the index range channel before it's closed.
This will prevent trySnapshot from trying to send a range to the index
range channel before it's closed.
Fixes DGRAPH-1574
This change is