Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default ratio of traces from 1 to 0.01. #5405

Merged
merged 1 commit into from
May 12, 2020
Merged

Change the default ratio of traces from 1 to 0.01. #5405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dgraph/cmd/alpha/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ they form a Raft group and provide synchronous replication.
" transaction is determined by its last mutation.")

// OpenCensus flags.
flag.Float64("trace", 1.0, "The ratio of queries to trace.")
flag.Float64("trace", 0.01, "The ratio of queries to trace.")
flag.String("jaeger.collector", "", "Send opencensus traces to Jaeger.")
// See https://github.com/DataDog/opencensus-go-exporter-datadog/issues/34
// about the status of supporting annotation logs through the datadog exporter
Expand Down
2 changes: 1 addition & 1 deletion dgraph/cmd/zero/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ instances to achieve high-availability.
flag.Bool("enable_sentry", true, "Turn on/off sending events to Sentry. (default on)")

// OpenCensus flags.
flag.Float64("trace", 1.0, "The ratio of queries to trace.")
flag.Float64("trace", 0.01, "The ratio of queries to trace.")
flag.String("jaeger.collector", "", "Send opencensus traces to Jaeger.")
// See https://github.com/DataDog/opencensus-go-exporter-datadog/issues/34
// about the status of supporting annotation logs through the datadog exporter
Expand Down