Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segmentation fault in query.go #5377

Merged
merged 1 commit into from
May 7, 2020
Merged

Fix segmentation fault in query.go #5377

merged 1 commit into from
May 7, 2020

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented May 6, 2020

Use the GetUids function which handles the case where the pointer is nil
correctly.

Fixes DGRAPH-1342


This change is Reviewable

Use the GetUids function which handles the case where the pointer is nil
correctly.

Fixes DGRAPH-1342
@martinmr martinmr requested a review from pawanrawal as a code owner May 6, 2020 19:59
Copy link
Contributor

@pawanrawal pawanrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@martinmr martinmr merged commit 3ced380 into master May 7, 2020
@martinmr martinmr deleted the martinmr/fix-sigsev branch May 7, 2020 17:19
martinmr added a commit that referenced this pull request May 7, 2020
Use the GetUids function which handles the case where the pointer is nil
correctly.

Fixes DGRAPH-1342
martinmr added a commit that referenced this pull request May 7, 2020
Use the GetUids function which handles the case where the pointer is nil
correctly.

Fixes DGRAPH-1342
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
Use the GetUids function which handles the case where the pointer is nil
correctly.

Fixes DGRAPH-1342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants