graphql: Start collecting and returning errors from remote remote GraphQL endpoints. #5328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks like you've broken the rule about a PR being about just one change ... looks like it's two things here 😉
The error changes look fine.
I want to investigate if there's a better way to the httpClient. Still looks strange to me how it's done.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @manishrjain and @MichaelJCompton)
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
…phQL endpoints. (hypermodeinc#5328) Earlier while resolving fields, errors returned from GraphQL endpoints were not propagated to the client. Fixed that with a test case. Fixes GRAPHQL-410.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier while resolving fields, errors returned from GraphQL endpoints were not propagated to the client. Fixed that with a test case. Fixes GRAPHQL-410.
We also now share the same
http.Clientto resolve fields and queries/mutations. Earlier we were instantiating a newhttp.ClientinmakeRequestfor resolving each field which is not recommended.This change is
Docs Preview: