release/v20.03: Update badger to commit cddf7c03451c (#5216) #5272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates badger to latest version dgraph-io/badger@cddf7c03451c . This PR also changes the following things. 1. Removes the second argument from `watermark.Init()` function. The second parameter was removed Init() function by commit dgraph-io/badger@09dd2e1 2. go.mod and go.sum updates 3. Change `pb.KV` in `pb.proto` to use `badgerpb2.KV` instead of `badgerpb2.KV`. The protobuf package was renamed from `pb` to `badgr.pb2` dgraph-io/badger@cddf7c0. NOTE - I've updated badger using `go get -u ... ` command. All the changes in go.mod file except badger are a side effect of badger update. Following new commits are being added from badger ``` git log 91c31ebe8c22...cddf7c03451c --oneline ``` ``` cddf7c0 Proto: Rename dgraph.badger.v2.pb to badgerpb2 (#1314) fd693e4 Support entry version in Write batch (#1310) f9332eb Disable go 1.11 builds on travis (#1306) 09dd2e1 Replace EventLog with Logger (#1203) 4f6763c Add leveled logging (#1249) 30eeec2 Update issue template (#1295) 8097259 Proto: make badger/v2 compatible with v1 (#1293) 2e708d9 Fail fast if cgo is disabled and compression is ZSTD (#1284) 6e032c0 Fix race condition in DoesNotHave (#1287) fa94030 Fix Sequence generates duplicate values (#1281) 69f35b3 Add go_package in .proto (#1282) 5f48d42 Disable eventlogging by default (#1285) 4b539b9 Update Project Status in readme.md (#1274) ``` (cherry picked from commit 7b37ddb)
jarifibrahim
requested review from
danielmai,
manishrjain,
martinmr,
MichaelJCompton and
a team
as code owners
danielmai
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
Thanks for updating the docs for the badger metrics. That will align with the changes in #5094.
Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @danielmai, @manishrjain, @martinmr, and @MichaelJCompton)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates badger to latest version
dgraph-io/badger@cddf7c03451c .
This PR also changes the following things.
watermark.Init()function. Thesecond parameter was removed Init() function by commit
dgraph-io/badger@09dd2e1
pb.KVinpb.prototo usebadgerpb2.KVinstead ofbadgerpb2.KV. The protobuf package was renamed frompbtobadgr.pb2dgraph-io/badger@cddf7c0.NOTE - I've updated badger using
go get -u ...command. All thechanges in go.mod file except badger are a side effect of badger update.
Following new commits are being added from badger
(cherry picked from commit 7b37ddb)
This change is
Docs Preview: