Avoid crashing live loader in case the network is interrupted. #5268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmai
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
danielmai
pushed a commit
that referenced
this pull request
Apr 22, 2020
Live loader currently runs `x.Fatalf` the moment it has a connection interrupt. Instead, it should just retry indefinitely. Also, remove a `%+v` error print for aborting transactions, which causes the entire error stack trace to be printed, which makes it look like a crash.
danielmai
pushed a commit
that referenced
this pull request
Apr 22, 2020
Live loader currently runs `x.Fatalf` the moment it has a connection interrupt. Instead, it should just retry indefinitely. Also, remove a `%+v` error print for aborting transactions, which causes the entire error stack trace to be printed, which makes it look like a crash.
This was referenced Apr 22, 2020
danielmai
added a commit
that referenced
this pull request
Apr 22, 2020
#5276) Cherry-pick of #5268 onto release/v1.2: Live loader currently runs `x.Fatalf` the moment it has a connection interrupt. Instead, it should just retry indefinitely. Also, remove a `%+v` error print for aborting transactions, which causes the entire error stack trace to be printed, which makes it look like a crash. Co-authored-by: Manish R Jain <[email protected]>
danielmai
added a commit
that referenced
this pull request
Apr 24, 2020
#5275) Live loader currently runs `x.Fatalf` the moment it has a connection interrupt. Instead, it should just retry indefinitely. Also, remove a `%+v` error print for aborting transactions, which causes the entire error stack trace to be printed, which makes it look like a crash. Co-authored-by: Manish R Jain <[email protected]>
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
…modeinc#5268) Live loader currently runs `x.Fatalf` the moment it has a connection interrupt. Instead, it should just retry indefinitely. Also, remove a `%+v` error print for aborting transactions, which causes the entire error stack trace to be printed, which makes it look like a crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live loader currently runs x.Fatalf the moment it has a connection interrupt. Instead, it should just retry indefinitely.
Also, remove a
%+verror print for aborting transactions, which causes the entire error stack trace to be printed, which makes it look like a crash.This change is