Send auth variable in custom jwt token.

[arijitAD]

This change is 

Docs Preview:

[MichaelJCompton]

Looks ok, just let me know if the couple of points I've asked about are ok.

Reviewable status: 0 of 4 files reviewed, 7 unresolved discussions (waiting on @arijitAD, @manishrjain, and @MichaelJCompton)

---

graphql/web/http.go, line 113 at r2 (raw file):

	ctx = x.AttachAuthorizationJwt(ctx, r)
	ctx = x.AttachAccessJwt(ctx, r)

Do we have to do something else here eventually? We'll be either having the enterprise jwt, or the GraphQL on ... or does this just work as is?

---

x/x.go, line 27 at r2 (raw file):

	"encoding/json"
	"fmt"
	"github.com/dgrijalva/jwt-go"

Is this dependency the right one? Looks like has lots of github stars. Is it the same thing that we take a JWT dependency on elsewhere?

Also make sure the processing code below is best practice for JWT or same as we do elsewhere in Dgraph.

---

x/x.go, line 216 at r2 (raw file):

	authVariables := jsonMap[CustomClaimsUrl].(map[string]interface{})
	return authVariables, nil

how or where are we going to verify the key the JWT is signed with?

[arijitAD]

Reviewable status: 0 of 4 files reviewed, 7 unresolved discussions (waiting on @golangcibot, @manishrjain, and @MichaelJCompton)

---

graphql/web/http.go, line 113 at r2 (raw file):

Previously, MichaelJCompton (Michael Compton) wrote…

	ctx = x.AttachAuthorizationJwt(ctx, r)
	ctx = x.AttachAccessJwt(ctx, r)

Do we have to do something else here eventually? We'll be either having the enterprise jwt, or the GraphQL on ... or does this just work as is?

Both store the values in different keys. Hence, both values can co-exist in the context. While extracting the value we query for the key. Should we prioritize if both headers are present?

---

x/x.go, line 195 at r1 (raw file):

Previously, golangcibot (Bot from GolangCI) wrote…

error strings should not be capitalized or end with punctuation or a newline (from golint)

Done.

---

x/x.go, line 201 at r1 (raw file):

Previously, golangcibot (Bot from GolangCI) wrote…

error strings should not be capitalized or end with punctuation or a newline (from golint)

Done.

---

x/x.go, line 206 at r1 (raw file):

Previously, golangcibot (Bot from GolangCI) wrote…

printf: Errorf call has arguments but no formatting directives (from govet)

Done.

---

x/x.go, line 212 at r1 (raw file):

Previously, golangcibot (Bot from GolangCI) wrote…

printf: Errorf call has arguments but no formatting directives (from govet)

Done.

---

x/x.go, line 27 at r2 (raw file):

Previously, MichaelJCompton (Michael Compton) wrote…

Is this dependency the right one? Looks like has lots of github stars. Is it the same thing that we take a JWT dependency on elsewhere?

Also make sure the processing code below is best practice for JWT or same as we do elsewhere in Dgraph.

Yes, It's the same library used in access_ee.go.

---

x/x.go, line 216 at r2 (raw file):

Previously, MichaelJCompton (Michael Compton) wrote…

how or where are we going to verify the key the JWT is signed with?

I have added a ToDo above to verify jwt before parsing it. We need a mechanism (via flag) to provide Dgraph the secret key so we can verify it.

[MichaelJCompton]

you can merge this and then start working on the other JWT bit

Reviewable status: 0 of 4 files reviewed, 7 unresolved discussions (waiting on @golangcibot, @manishrjain, and @MichaelJCompton)