Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap errors thrown in posting/list.go for easier debugging. #4880

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Wrap errors thrown in posting/list.go for easier debugging. #4880

merged 1 commit into from
Mar 4, 2020

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Mar 3, 2020 •
edited by manishrjain
Loading

This change is Reviewable

@martinmr martinmr requested a review from manishrjain as a code owner March 3, 2020 21:34
danielmai
danielmai approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

posting/list.go, line 766 at r1 (raw file):

	kv.Version = out.newMinTs
	key, err := x.GetSplitKey(baseKey, startUid)
	x.Check(err)

This changes the error check here from a log.Fatal to a returned error. If we're OK with this change, then LGTM.

martinmr
martinmr commented Mar 4, 2020
View reviewed changes
Copy link
Contributor Author

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be ok now that the errors are properly wrapped. I am also not sure why I did that originally when the function already returns an error.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

@martinmr martinmr merged commit 0e3c4b0 into master Mar 4, 2020
@martinmr martinmr deleted the martinmr/list-wrapf branch March 4, 2020 01:16
martinmr added a commit that referenced this pull request Mar 4, 2020
@martinmr
Wrap errors thrown in posting/list.go for easier debugging. (#4880)
60825d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmai danielmai danielmai approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinmr @danielmai