-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split posting lists recursively. #4867
Conversation
Currently, split posting lists are split in one go. This means that the resulting splits will be added to the list even if they are still too big. This change recursively splits the parts of the lists until all of them are smaller than the threshold.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @manishrjain and @martinmr)
posting/list.go, line 1247 at r2 (raw file):
func (out *rollupOutput) recursiveSplit() { // Call splitUpList. Otherwise the map of startUids to parts won't be initialized. out.splitUpList()
Do you need to call this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @golangcibot and @manishrjain)
posting/list.go, line 1221 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
File is not
gofmt
-ed with-s
(fromgofmt
)}
Done.
posting/list.go, line 1247 at r2 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Do you need to call this here?
Done. Simplified the logic.
Currently, split posting lists are split in one go. This means that the resulting splits will be added to the list even if they are still too big. This change recursively splits the parts of the lists until all of them are smaller than the threshold.
Currently, split posting lists are split in one go. This means that the resulting splits will be added to the list even if they are still too big. This change recursively splits the parts of the lists until all of them are smaller than the threshold.
Currently, split posting lists are split in one go. This means that the
resulting splits will be added to the list even if they are still too
big. This change recursively splits the parts of the lists until all of
them are smaller than the threshold.
This change is
Docs Preview: