-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HTTP admin endpoints #4754
Conversation
Just a point, wouldn't it be nice to leave that for compatibility? Some users might not like to be forced to use GraphQL for these operations. Sending curl commands would get bigger and more complex. e.g:
Instead of just
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pawanrawal)
graphql/admin/export.go, line 51 at r1 (raw file):
format := worker.DefaultExportFormat fmt.Printf("input: %+v\n", input)
fmt.printfs?
This reverts commit 8fa2fd9.
These endpoints are now served via the GraphQL Admin API and hence we are removing the HTTP endpoints. Another PR for updating the docs will follow.
This change is
Docs Preview: