Drain apply channel when a snapshot is received #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 13, 2019 13:22
…y status while snapshot is applied. Fixes DGRAPH-671 and DGRAPH-672
golangcibot
reviewed
Nov 14, 2019
martinmr
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain and @parasssh)
manishrjain
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @parasssh)
parasssh
commented
Nov 14, 2019
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @golangcibot)
worker/draft.go, line 923 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
File is not
gofmt-ed with-s(fromgofmt)default:
Done.
parasssh
commented
Nov 14, 2019
There was a problem hiding this comment.
Dismissed @golangcibot from a discussion.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drain apply channel when a snapshot is received; set node to unhealthy status while snapshot is applied. Fixes DGRAPH-671 and DGRAPH-672
This change is