Check for n.Raft() to be nil

[mangalaman93]

fixes #4053

This change is 

[pullrequest]

✅ A review job has been created and sent to the PullRequest network.

---

@mangalaman93 you can click here to see the review status or cancel the code review job.

[pullrequest]

	1 Message
✅	It looks like the description for this pull request is either blank or very short. Adding a high-level summary will help our reviewers provide better feedback. Feel free to include questions for PullRequest reviewers and make specific feedback requests.

[martinmr]

Reviewed 1 of 1 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

[pullrequest]

A good straightforward fix. No comments.

---

Reviewed with ❤️ by PullRequest

[manishrjain]

Got a comment.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @balajijinnah and @mangalaman93)

---

worker/snapshot.go, line 168 at r1 (raw file):

	}

	raftNode := n.Raft()

I like to generally avoid one-time use variables. A good way to do this would be to put an OR next to n == nil.

if n == nil || n.Raft() == nil { ... }

[mangalaman93]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @balajijinnah and @manishrjain)

---

worker/snapshot.go, line 168 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

I like to generally avoid one-time use variables. A good way to do this would be to put an OR next to n == nil.

if n == nil || n.Raft() == nil { ... }

I was trying to avoid calling n.Raft() twice because it internally acquires a lock. Does it still seem okay to do that?

[manishrjain]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @balajijinnah and @mangalaman93)

---

worker/snapshot.go, line 168 at r1 (raw file):

Previously, mangalaman93 (Aman Mangal) wrote…

I was trying to avoid calling n.Raft() twice because it internally acquires a lock. Does it still seem okay to do that?

Really not a big deal. This func is super expensive already.

[pullrequest]

⚠️ Warning

PullRequest detected a force-push on this branch. This may have caused some information to be lost, and additional time may be required to complete review of the code. Read More