Skip to content

Fix bug in backup KeyToList function. #3832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix bug in backup KeyToList function. #3832

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c153a8
Fix bug in backup KeyToList function.
martinmr Aug 16, 2019
11a84b9
Call it.Next inside ReadPostingList instead.
martinmr Aug 17, 2019
b221172
Restore comment.
martinmr Aug 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ee/backup/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,15 +264,12 @@ func (pr *Processor) toBackupList(key []byte, itr *badger.Iterator) (*bpb.KVList
return list, nil
}

// Manually advance the iterator. This cannot be done in the for
// statement because ReadPostingList advances the iterator so this
// only needs to be done for BitSchemaPosting entries.
itr.Next()

default:
return nil, errors.Errorf(
"Unexpected meta: %d for key: %s", item.UserMeta(), hex.Dump(key))
}

itr.Next()
}

// This shouldn't be reached but it's being added here because the golang
Expand Down