Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in backup KeyToList function. #3832

Closed
wants to merge 3 commits into from
Closed

Fix bug in backup KeyToList function. #3832

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c153a8
Fix bug in backup KeyToList function.
martinmr Aug 16, 2019
11a84b9
Call it.Next inside ReadPostingList instead.
martinmr Aug 17, 2019
b221172
Restore comment.
martinmr Aug 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ee/backup/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,10 +263,6 @@ func (pr *Processor) toBackupList(key []byte, itr *badger.Iterator) (*bpb.KVList
if item.DiscardEarlierVersions() || item.IsDeletedOrExpired() {
return list, nil
}

// Manually advance the iterator. This cannot be done in the for
// statement because ReadPostingList advances the iterator so this
// only needs to be done for BitSchemaPosting entries.
itr.Next()

default:
Expand Down
3 changes: 1 addition & 2 deletions posting/mvcc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,7 @@ func ReadPostingList(key []byte, it *badger.Iterator) (*List, error) {
return nil, err
}
l.minTs = item.Version()
// No need to do Next here. The outer loop can take care of skipping
// more versions of the same key.
it.Next()
return l, nil
case BitDeltaPosting:
err := item.Value(func(val []byte) error {
Expand Down