Lock versions for protobuf gen libraries. #3752
Conversation
* Clone golang/protobuf and gogo/protobuf libraries to latest released versions: * golang/protobuf: v1.3.2 * gogo/protobuf: v1.2.1 * Regenerate protos/pb/pb.pb.go
There was a problem hiding this comment.
Running make regenerate re-clones the specific version of golang/protobuf and gogo/protobuf in the GOPATH. It does not revert back to the previously cloned state if they already existed in the GOPATH before.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @manishrjain)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai and @manishrjain)
protos/depcheck.sh, line 7 at r1 (raw file):
readonly PROTOCMINVER="3.6.1" readonly PROTOGOREQVER="v1.3.2" readonly PROTOGOGOREQVER="v1.2.1"
What's the difference between these two constants. The names are pretty similar so it's a bit confusing.
It looks like the versions of go and gogo but a comment would be helpful.
protos/Makefile
Outdated
|
|
||
| .PHONY: golang_protobuf | ||
| golang_protobuf: | ||
| @echo "\033[0;31mRemoving $(GOPATH)/src/github.com/golang/protobuf\033[0m" |
There was a problem hiding this comment.
The color codes are unnecessary and do not make much difference to the output. Can avoid it.
| @@ -26,16 +30,31 @@ help: | |||
| .PHONY: clean | |||
| clean: | |||
| @mkdir -p pb && rm -f pb/pb.pb.go | |||
| @rm -f $(GOBIN)/protoc-gen-go | |||
There was a problem hiding this comment.
regenerate is doing check clean golang_protobuf gogo_protobuf and clean is Phony. So every step will run every time which may be fine because we won't be running make regenerate too often. Could be problematic while I making changes to the proto file though.
|
protos/Makefile, line 42 at r1 (raw file): Previously, mangalaman93 (Aman Mangal) wrote…
Done. Removed the colors. |
|
protos/depcheck.sh, line 7 at r1 (raw file): Previously, martinmr (Martin Martinez Rivera) wrote…
Done. Renamed the variables and added comments. Should be clearer now. |
|
protos/Makefile, line 33 at r1 (raw file): Previously, mangalaman93 (Aman Mangal) wrote…
Every directive in the Makefile is .PHONY. Is there an issue with removing the generated code and protoc-gen-* binaries when running |
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @danielmai, @manishrjain, and @martinmr)
protos/Makefile, line 33 at r1 (raw file):
Previously, danielmai (Daniel Mai) wrote…
Every directive in the Makefile is .PHONY. Is there an issue with removing the generated code and protoc-gen-* binaries when running
make regenerate?
It just make take time to run all the steps again and again.
|
Protobuf-tooling version locking is done by #5291. It installs the versions specified in go.mod. Closing this PR. |
versions:
This change is