Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't read data posting lists in certain cases #3713

Merged
merged 4 commits into from
Jul 24, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix a test failure by retrieving in case of DEL operation.
  • Loading branch information
manishrjain committed Jul 23, 2019

Unverified

The committer email address is not verified.
commit 89a079bed8f804577239e4eaa2f2862dc8e3b1bc
4 changes: 2 additions & 2 deletions worker/mutation.go
Original file line number Diff line number Diff line change
@@ -90,8 +90,8 @@ func runMutation(ctx context.Context, edge *pb.DirectedEdge, txn *posting.Txn) e
case su.GetValueType() == pb.Posting_UID && !su.GetList():
// Single UID, not a list.
fn = txn.Get
case edge.Op == pb.DirectedEdge_DEL && string(edge.Value) == x.Star:
// Delete all. To keep things simple, don't worry about whether indexed or not.
case edge.Op == pb.DirectedEdge_DEL:
// Covers various delete cases to keep things simple.
fn = txn.Get
default:
// Reverse index doesn't need the posting list to be read. We already covered count index,