Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the normalize limit to be changed via a flag. #3490

Merged
merged 2 commits into from
May 30, 2019
Merged

Allow the normalize limit to be changed via a flag. #3490

merged 2 commits into from
May 30, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented May 30, 2019 •
edited by manishrjain
Loading

This change is Reviewable

@martinmr martinmr requested review from manishrjain and danielmai May 30, 2019 21:59
danielmai
danielmai approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

@martinmr martinmr merged commit ff5ee1e into release/v1.0 May 30, 2019
@martinmr martinmr deleted the martinmr/cb-normalize-flag branch May 30, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmai danielmai danielmai approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinmr @danielmai