Code

Fix int/float conversion to bool#2893

Code

Merged

srfrog merged 14 commits intomasterhypermodeinc/dgraph:masterfrom srfrog/make_zero_false_againhypermodeinc/dgraph:srfrog/make_zero_false_againCopy head branch name to clipboardJan 22, 2019

+294-95

Commits

Commits on Jan 14, 2019

• fix conversion from int/float to bool to make zero equal to false

  

  srfrog

  committed
  64bcc4c

  Copy full SHA for 64bcc4c

• added tests for int/float -> bool conversion

  

  srfrog

  committed
  ebf2239

  Copy full SHA for ebf2239

Commits on Jan 16, 2019

• change convert empty string to boolean false

  

  srfrog

  committed
  0dc2d44

  Copy full SHA for 0dc2d44

• update test to account for empty string to bool false

  

  srfrog

  committed
  40521fc

  Copy full SHA for 40521fc

• Merge branch 'master' of github.com:/dgraph-io/dgraph into srfrog/make_zero_false_again

  

  srfrog

  committed
  1360f53

  Copy full SHA for 1360f53

• added truthy value test

  

  srfrog

  committed
  33080a8

  Copy full SHA for 33080a8

Commits on Jan 17, 2019

• added falsy value test

  

  srfrog

  committed
  a42954f

  Copy full SHA for a42954f

• simplified tests and added more cases

  

  srfrog

  committed
  b1cfb5d

  Copy full SHA for b1cfb5d

• refactor tests for legibility and support

  

  srfrog

  committed
  e1b5050

  Copy full SHA for e1b5050

• Merge branch 'master' of github.com:/dgraph-io/dgraph into srfrog/make_zero_false_again

  

  srfrog

  committed
  232b37b

  Copy full SHA for 232b37b

Commits on Jan 22, 2019

• empty binary should be false

  

  srfrog

  committed
  0cb91bf

  Copy full SHA for 0cb91bf

• compacted tests a bit except when failure cases are expected

  

  srfrog

  committed
  e4c1b9b

  Copy full SHA for e4c1b9b

• Merge branch 'master' of github.com:/dgraph-io/dgraph into srfrog/make_zero_false_again

  

  srfrog

  committed
  d765b5b

  Copy full SHA for d765b5b

• fixed typo

  

  srfrog

  committed
  1b35f79

  Copy full SHA for 1b35f79