Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix couple of issues #1478

Closed
wants to merge 2 commits into from
Closed

Fix couple of issues #1478

wants to merge 2 commits into from

Conversation

pawanrawal
Copy link
Contributor

@pawanrawal pawanrawal commented Sep 18, 2017

Fixes #1477 and #1464.


This change is Reviewable

@manishrjain
Copy link
Contributor

:lgtm:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@janardhan1993
Copy link
Contributor

:lgtm:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


client/client.go, line 298 at r1 (raw file):

	if len(val) == 0 {
		val = "_nil_"

Have similar checks at server side also, incase if we support grpc clients in other languages also.


Comments from Reviewable

@pawanrawal
Copy link
Contributor Author

Merged to master.

@pawanrawal pawanrawal closed this Sep 18, 2017
@pawanrawal pawanrawal deleted the pawan/more-fixes branch September 18, 2017 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants