Skip to content

sort and validate facets coming on grpc endpoint #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2017
Merged

Conversation

janardhan1993
Copy link
Contributor

@janardhan1993 janardhan1993 commented Sep 7, 2017

This change is Reviewable

@pawanrawal
Copy link
Contributor

:lgtm:


Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.


rdf/parse.go, line 319 at r1 (raw file):

	}

	return facets.SortAndValidateFacets(rnq.Facets)

Remove from here


Comments from Reviewable

@janardhan1993
Copy link
Contributor Author

Review status: 0 of 6 files reviewed at latest revision, 1 unresolved discussion.


rdf/parse.go, line 319 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Remove from here

Done.


Comments from Reviewable

@janardhan1993 janardhan1993 merged commit 6590aca into master Sep 7, 2017
@janardhan1993 janardhan1993 deleted the bug/facets branch September 7, 2017 06:20
janardhan1993 pushed a commit that referenced this pull request Sep 7, 2017
* sort and validate facets coming on grpc endpoint
fixes #1418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants